Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/#261 티켓 디테일 매수별 인디케이터 및 간격 수정 / 네이밍 수정 #262

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

longlivedrgn
Copy link
Collaborator

@longlivedrgn longlivedrgn commented Jul 2, 2024

작업한 내용

  • 티켓 디테일에서 매수 별 인디케이터 유무 및 간격을 수정했어요.
    • 1매 or 1매 이상
  • 예매자 -> 방문자로 네이밍 수정 및 예매 -> 결제로 네이밍 변경했어요.

스크린샷

관련 이슈

@longlivedrgn longlivedrgn self-assigned this Jul 2, 2024
@longlivedrgn longlivedrgn changed the title Chore/#261 티켓 디테일 매수별 인디케이터 및 간격 수정 Chore/#261 티켓 디테일 매수별 인디케이터 및 간격 수정 / 네이밍 수정 Jul 3, 2024
Copy link
Collaborator

@wngus4296 wngus4296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했다 용재!!
오타 수정이랑 GradientBackgroundView 함수 관련 코멘트 남겼는데 확인부탁합니당 🫡

@@ -150,7 +150,7 @@ extension UserInfoInputView {
private func configureTicketHolderUI() {
self.configureDefaultUI()

self.titleLabel.text = "예매자 정보"
self.titleLabel.text = "방묹 정보"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 친구 아파요

Comment on lines 92 to 101
func setData(with posterImageURL: String, concertName: String) {
self.posterImageView.setImage(with: posterImageURL)
self.tagLabel.text = concertName

let path = CGMutablePath()
path.move(to: CGPoint(x: 20, y: 445))
path.addLine(to: CGPoint(x: self.frame.width - 20, y: 445))

self.shapeLayer.path = path
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 함수가 혹시 사용이 되는걸까?!

self.concertDetailBackgroundView.setData(
            with: entity.posterURLPath,
            concertName: entity.title,
            ticketCount: entity.ticketInformations.count
        )

TicketDetailViewController의 ticketCount가 계속 들어가는 것 같아서!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저 친구 미쳐 지우지 못했네요..

@longlivedrgn longlivedrgn merged commit a741e33 into develop Jul 3, 2024
@longlivedrgn longlivedrgn deleted the chore/#261-TicketDetailIndicator branch July 3, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] 티켓 디테일 매수별 인디케이터 유무 수정
2 participants