CompleteScreen 가로모드, 태블릿 대응 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
가로모드일때 이모지가 ide 에서 보이는 이미지와 다르게 보이는 것은 유감
…dscape-support # Conflicts: # feature/complete/src/main/kotlin/com/nexters/bandalart/android/feature/complete/CompleteScreen.kt
Galaxy 23, Galaxy 23 Ultra 두 기종의 크기가 유의미하게 다르지 않으므로, 디바이스의 세로모드, 가로모드 확인용 preview 로 devicePreview annotation class 를 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> 따라서 세로 모드, 가로모드일때 각각 다른 화면이 그려지도록 분기 처리(lottie 는 Emoji 로 대체)
verticalScroll 추가, 가로모드일때 이모지가 ide 에서 보이는 이모지와 다르게 보이는 것은 유감(OS 에 따라 다르게 보이는듯 함)