Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #28

Closed
yanglongji opened this issue Dec 3, 2017 · 2 comments
Closed

bug #28

yanglongji opened this issue Dec 3, 2017 · 2 comments
Labels

Comments

@yanglongji
Copy link

return this.presentAlert(result, metadata);
should be
return this.presentAlert(result, this.getPlatformData(metadata));

@yanglongji
Copy link
Author

actually, should be :
return this.presentAlert(result, this.getPlatformData(metadata)).then(()=>{
resolve()
});
because the resolve used in alert() not the resolve in here, so if the alert return resolve(), here should also return resolve()

@MichaelMarner
Copy link
Contributor

Thanks for reporting this issue. I should be able to have a fix out by Friday, but PRs are welcome if you want to have a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants