Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC Plugin: MBTA CharlieCard Updates #88

Merged
merged 10 commits into from
Apr 10, 2024
Merged

NFC Plugin: MBTA CharlieCard Updates #88

merged 10 commits into from
Apr 10, 2024

Conversation

zacharyweiss
Copy link
Contributor

@zacharyweiss zacharyweiss commented Apr 10, 2024 •
edited by Willy-JL
Loading

What's new

  • Major refactor for code readability
  • ASCII art depicting layout, (un)known fields, constants
  • Fare gate ID fixes & cleanup
  • Pass parsing testing (WIP — debug only)
  • Variadic output string fields accounting for some edge cases
  • Detailed comments

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL Willy-JL added the enhancement New enhancement or request label Apr 10, 2024
Willy-JL
Willy-JL approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm )

@Willy-JL Willy-JL merged commit 77747fb into Next-Flip:dev Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@zacharyweiss zacharyweiss

Labels
enhancement New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyweiss @Willy-JL