Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Issue String and Implement Case in Hintcode. Sha256AndBlake2sInput Hint #540 #609

Closed
wants to merge 5 commits into from

Conversation

D240021
Copy link

@D240021 D240021 commented Jul 25, 2024

Changes:

  • Added issue string to hintcode.go
  • Implemented corresponding case in zerohint_others.go
  • Declared the required method for issue handling

Pending:

  • Implement body method for issue handling
  • Unit test for Sha256AndBlake2sInput Hint
  • Integration tests

Important
I'm working on it, I'll upload what's missing soon.
I would greatly appreciate it if you could give me feedback of my work.
Thank you for trusting me!

D240021 and others added 2 commits July 25, 2024 08:20
…zerohint_others.go and declared the required method for issue handling
@MaksymMalicki
Copy link
Contributor

Hey, could you provide the issue code, which this PR resolves? Also it would be nice to include the issue name in the title of the PR. Thanks!

@D240021 D240021 changed the title Add Issue String and Implement Case in Hintcode Add Issue String and Implement Case in Hintcode. Sha256AndBlake2sInput Hint #540 Jul 25, 2024
@TAdev0
Copy link
Contributor

TAdev0 commented Jul 27, 2024

hi @D240021 ,

what does your hint implementation correspond to?

Sha256AndBlake2sInput is :

Sha256AndBlake2sInput string = "ids.full_word = int(ids.n_bytes >= 4)"

and this is what you added in the hintcode

@TAdev0 TAdev0 closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants