Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo0 hint pow #306

Merged
merged 9 commits into from
Mar 29, 2024
Merged

Cairo0 hint pow #306

merged 9 commits into from
Mar 29, 2024

Conversation

MaksymMalicki
Copy link
Contributor

No description provided.

@MaksymMalicki MaksymMalicki linked an issue Mar 13, 2024 that may be closed by this pull request
Closed
@quasilyte
Copy link
Contributor

quasilyte commented Mar 14, 2024

I don't think that it would work if you try running it on a compiled code.
This is why I recommend testing every hint locally on a full run at least once.
Our tests only check for an internal implementation and they're not taking the execution context into account.
It would be inconvenient to merge an implementation that passes our CI tests (as our testing approach is flawed right now) and then discover that some of the hints are not working on the integration level.

To run the code, you need to compile a Cairo file with cairo-compile and then run the cmd/cli over that compiled JSON. The Cairo file should contain the pow function calls. You can use serialize_word to print the output. Compare it with cairo-run output to validate the results.

There is also an issue that even if this hint is implemented, it would fail due to #284.
This is the reason why I re-assigned the hint-related issue to myself as it has some blockers.

@cicr99 cicr99 merged commit aac12f3 into main Mar 29, 2024
4 checks passed
@cicr99 cicr99 deleted the cairo0_hint-pow branch March 29, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pow
3 participants