using guava retry logic and adding interal sql based hive table parti… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 17, 2017 16:49
tgianos
approved these changes
Mar 20, 2017
| if (!useLocalMetastore) { | ||
| client = createThriftClient(); | ||
| if (configuration.containsKey(HiveConfigConstants.USE_FASTHIVE_SERVICE)) { |
There was a problem hiding this comment.
Do we need to expose this as a configuration?
| * @throws TException | ||
| * @throws ConnectorException | ||
| */ | ||
| private <V> V retryExec(final String functionName, |
There was a problem hiding this comment.
We should not be building the retryer for every call.
ajoymajumdar
pushed a commit
that referenced
this pull request
May 11, 2017
#71) * using guava retry logic and adding interal sql based hive table partition services * fixing the functionalTest failure * fixing the style check * changing functionalTest to use hive fast service * changing to use existing embeded hive metastore impl * using hivefastservice in functionalTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.