Upgrade to Spring boot 2.7.6 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insyncoss
reviewed
Mar 13, 2023
| @@ -76,9 +77,10 @@ dependencies { | |||
| runtime(project(":metacat-connector-druid")) | |||
|
|
|||
| runtime("io.springfox:springfox-swagger-ui") | |||
| runtime("org.webjars:hal-browser") | |||
| runtime("org.webjars:hal-browser:3325375") | |||
There was a problem hiding this comment.
Curious what the reason for this pinning is
There was a problem hiding this comment.
The new Netflix BOm does not have recommendations for this artifact, so we have to specify a specific version
| @@ -123,6 +123,16 @@ class MetacatSmokeSpec extends Specification { | |||
| if (metadata != null) { | |||
| newTable.getMetadata() == null? newTable.setMetadata(metadata): newTable.getMetadata().putAll(metadata) | |||
| } | |||
|
|
|||
| if (tableName == 's3-mysql-db') { | |||
There was a problem hiding this comment.
Would it make sense to just set the owner for all tables created
There was a problem hiding this comment.
It is mandated only for the S3 connector, but let me try and see what breaks.
insyncoss
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.