Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL Connector Implementation #50

Merged
merged 1 commit into from
Feb 24, 2017
Merged

MySQL Connector Implementation #50

merged 1 commit into from
Feb 24, 2017

Conversation

tgianos
Copy link
Contributor

@tgianos tgianos commented Feb 23, 2017

This PR adds a new connector for MySQL without the Presto dependency.

@tgianos tgianos self-assigned this Feb 23, 2017
@ajoymajumdar ajoymajumdar merged commit 76cd435 into Netflix:canonical-types Feb 24, 2017
zhljen
zhljen reviewed Feb 24, 2017
View reviewed changes
Copy link
Contributor

@zhljen zhljen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

...dbc/src/main/java/com/netflix/metacat/connector/jdbc/services/JdbcConnectorTableService.java
this.dataSource = dataSource;
this.typeConverter = typeConverter;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there're two @nonnull @nonnull

ajoymajumdar pushed a commit that referenced this pull request May 11, 2017
@tgianos @ajoymajumdar
MySQL Connector Implementation (#50)
ac47ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhljen zhljen zhljen left review comments

@ajoymajumdar ajoymajumdar ajoymajumdar approved these changes

Assignees

@tgianos tgianos

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgianos @zhljen @ajoymajumdar