Publish the list of partition ids on TABLE_PARTITION_UPDATE event #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insyncoss
force-pushed
the
publish-parts
branch
7 times, most recently
from
9c15739
to
1c98c30
Compare
| * @return list of partition ids from the input list | ||
| */ | ||
| protected static List<String> getPartitionNameListFromDtos(final List<PartitionDto> partitionDtos) { | ||
| if (partitionDtos.size() > PARTS_UPDATED_LIST_MAX_SIZE) { |
There was a problem hiding this comment.
We should make PARTS_UPDATED_LIST_MAX_SIZE configurable.
| return Collections.emptyList(); | ||
| } | ||
| return partitionDtos.stream() | ||
| .map(PartitionDto::getName) |
There was a problem hiding this comment.
Minor: We can as well make one mapper call with dto -> dto.getName().getPartitionName()
raveeram
previously approved these changes
Jul 25, 2021
| @@ -174,6 +179,25 @@ public TablePartitionsUpdatePayload createTablePartitionsUpdatePayload( | |||
| .collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| /** | |||
| * get partition name list from list of partitionDtos. The returned list is capped at | |||
| * the first PARTS_UPDATED_LIST_MAX_SIZE elements, if there are more than that number of elements | |||
There was a problem hiding this comment.
should we just call this PARTITIONS_UPDATED_LIST_MAX_SIZE
ArtfulCoder
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.