Minor changes. #390
Merged
Minor changes. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client to retry on HTTP 429. Fixed issue where druid getTable was throwing an HTTP 500 and not HTTP 404 on table not found.
raveeram
reviewed
May 18, 2020
| final ObjectNode node = this.druidClient.getLatestDataByName(name.getTableName()); | ||
| final DataSource dataSource = DruidConverterUtil.getDatasourceFromLatestSegmentJsonObject(node); | ||
| return this.druidConnectorInfoConverter.getTableInfoFromDatasource(dataSource); | ||
| } catch (MetacatException e) { |
There was a problem hiding this comment.
Any metacat exception is rethrown as a TableNotFound?
There was a problem hiding this comment.
Method getLatestDataByName throws this specific error when segments are not found.
raveeram
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the 429 errors as RetryableException for the client to retry on HTTP 429. Fixed issue where druid getTable was throwing an HTTP 500 and not HTTP 404 on table not found.