Add a TABLE_RENAME SNS Message Type #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raveeram
commented
Feb 19, 2020
- Today, Rename events are clubbed into the TABLE_UPDATE message type. This will help downstream event consumers (like Microbots) avoid processing irrelevant Update messages.
ajoymajumdar
approved these changes
Feb 19, 2020
zhljen
reviewed
Feb 19, 2020
| @@ -313,28 +317,39 @@ public void notifyOfTableUpdate(final MetacatUpdateTablePostEvent event) { | |||
| Metrics.CounterSNSNotificationTableUpdate.getMetricName()); | |||
| } | |||
|
|
|||
| private UpdateTableMessage createUpdateTableMessage( | |||
| private UpdateOrRenameTableMessageBase createUpdateorRenameTableMessage( | |||
There was a problem hiding this comment.
I feel it's better to have two methods createUpdateTableMessage() and createRenameTableMessage(), each of them will call this createUpdateorRenameTableMessage() with the corresponding message type.
There was a problem hiding this comment.
Thanks Zhen. Normally I'd prefer the same, but in this case, the difference is just a statement (given the somewhat large method signature). I figured this should suffice as a middle-ground.
zhljen
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.