Changes to support common view #377
Conversation
| /** | ||
| * Iceberg table type. | ||
| */ | ||
| public static final String COMMON_VIEW = "common_view"; |
There was a problem hiding this comment.
yes, this is a key in table paramters, e.g.
parameters: {
previous_metadata_location: "",
metadata_location: "s3n:https://netflixxee.metadata.json",
common_view: "true",
table_type: "VIRTUAL_VIEW"
},
| return; | ||
| } | ||
| } | ||
| final String message = String.format("Originally table %s is not type of iceberg ", tableName); |
There was a problem hiding this comment.
Message should have the correct context in terms of iceberg vs common-view.
There was a problem hiding this comment.
The validation error here is that "we can't update a table that is not an iceberg table or not a common view". I have updated the message.
I don't think we can't tell if the table should be an iceberg table/common view but it is not so that we can give out the message separately.
| @@ -159,11 +170,36 @@ public void update(final ConnectorRequestContext requestContext, final TableInfo | |||
| } else { | |||
| directSqlTable.updateIcebergTable(tableInfo); | |||
| } | |||
| } else if (connectorContext.getConfig().isCommonViewEnabled() | |||
There was a problem hiding this comment.
We should refactor this to handle common-view separately in a different method (handleCommonView). Also refactor the iceberg code to handleIcebergTable)
There was a problem hiding this comment.
Yes, refactored as suggested.
No description provided.