Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to iceberg 0.6.2 and fix for handling timestamp query in iceberg. #317

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

zhljen
Copy link
Contributor

@zhljen zhljen commented Dec 18, 2018

No description provided.

@zhljen zhljen added this to the 1.2.0 milestone Dec 18, 2018
@zhljen zhljen self-assigned this Dec 18, 2018
private Pair<String, Object> getExpressionKeyValue(final Object lhs,
final Object rhs) {
if (isIcebergTimestamp(lhs)) {
return new ImmutablePair<>(lhs.toString(), ((BigDecimal) rhs).longValue());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason using ImmutablePair instead of Map.Entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pair is more appropriate here since it can only have two values left hand value and right hand value.

@zhljen zhljen merged commit 3b39dc9 into Netflix:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants