Mapping SQLException of too many connection to TOO_MANY_REQUEST status #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like other Metacat exceptions (MetacatException), we need to define an Exception specifically for 429. We should have this mapping of Pool exhaust error either in the connectors or in the controller RequestWrapper, instead of in the ExceptionMapper. |
zhljen
force-pushed
the
master
branch
3 times, most recently
from
d6ca11a
to
842d643
Compare
|
Updated to address comments. |
|
Changes look good. You also want to modify com.netflix.metacat.client.module.MetacatErrorDecoder. |
|
Updated based on suggestion. |
ajoymajumdar
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.