Add setTags() api in tagController #264
Conversation
| success = true | ||
| sleep( Math.abs(new Random().nextInt() % 600) + 500) | ||
| } catch (MetacatNotFoundException e) { | ||
| print "ignore transient Exception" |
There was a problem hiding this comment.
Why are we getting transient exception?
| assert ret2_new.size() == 0 | ||
|
|
||
| cleanup: | ||
| api.deleteTable(catalogName, databaseName, tableName) |
There was a problem hiding this comment.
Does this cleanup the metadata/tags too?
There was a problem hiding this comment.
You want to include these databses in metacat.definition.metadata.delete.enableDeleteForQualifiedNames option in docker-compose.yml so that the metadata gets deleted too.
There was a problem hiding this comment.
why delete the metadata of them as part of the tag tests? For testing cleanup purpose?
There was a problem hiding this comment.
yes, for test cleanup.
| final QualifiedName name = tagCreateRequestDto.getName(); | ||
| final Set<String> tags = new HashSet<>(tagCreateRequestDto.getTags()); | ||
| final MetacatRequestContext metacatRequestContext = MetacatContextManager.getContext(); | ||
| if (name.getType().equals(QualifiedName.Type.TABLE)) { |
There was a problem hiding this comment.
We should use a switch statement. If none of the type matches throw an exception.
There was a problem hiding this comment.
ok. think we need a qualifiedName validation function.
| final MetacatRequestContext metacatRequestContext = MetacatContextManager.getContext(); | ||
| final QualifiedName name = tagRemoveRequestDto.getName(); | ||
|
|
||
| if (name.getType().equals(QualifiedName.Type.TABLE)) { |
There was a problem hiding this comment.
Same comments as above.
| @Consumes(MediaType.APPLICATION_JSON) | ||
| @Produces(MediaType.APPLICATION_JSON) | ||
| Set<String> setTags( | ||
| TagCreateRequestDto tagCreateRequestDto |
There was a problem hiding this comment.
Nice. We should start following this pattern of creating dtos for post objects.
| environment: | ||
| - TARGETS=postgresql:5432,cassandra:9042,hive-metastore-db:3306,druid:8081 | ||
| - TARGETS=postgresql:5432,hive-metastore-db:3306 |
There was a problem hiding this comment.
Add comments that we will reinstate the cassandra and druid tests once we figure a lightweight docker image for the same.
To support tags for catalog, database, and table.