Fixing hive partition getQualifiedName, adding resolver ending point #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgianos
approved these changes
May 4, 2017
| @@ -60,3 +60,7 @@ servo_version=0.8.3 | |||
| spock_version=1.0-groovy-2.4 | |||
| swagger_version=1.3.12 | |||
| testing_mysql_server_version=0.1 | |||
|
|
|||
| ## speed up the build process | |||
| * @author zhenl | ||
| * @since 1.0.0 | ||
| */ | ||
| @Data |
There was a problem hiding this comment.
if this is a DTO please make the variables final. That way lombok won't create setters.
ajoymajumdar
reviewed
May 4, 2017
| @@ -519,6 +523,12 @@ class MetacatFunctionalSpec extends Specification { | |||
| database.tables.contains(tableName) | |||
|
|
|||
| when: | |||
| def resovlerRep = resolverApi.resolveByUri(false, resolveByUridto) | |||
There was a problem hiding this comment.
Please add a test case with prefixSearch=true
ajoymajumdar
reviewed
May 4, 2017
| @@ -788,6 +802,16 @@ class MetacatFunctionalSpec extends Specification { | |||
| response.updated.empty | |||
|
|
|||
| when: | |||
| def resovlerRep = resolverApi.resolveByUri(false, resolveByUridto) | |||
There was a problem hiding this comment.
Same here. Please add a test case with prefixSearch=true
ajoymajumdar
pushed a commit
that referenced
this pull request
May 11, 2017
…111) * renaming enablesearchable * fixing hive partition getqualifiedName function, adding resolver endingpoint * adding test for resolveByUri using prefixSearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.