Disable sdl comments in executable schema #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbakker
reviewed
Jun 10, 2024
paulbakker
reviewed
Jun 10, 2024
paulbakker
requested changes
Jun 10, 2024
srinivasankavitha
approved these changes
Jun 17, 2024
Remove from graphql-dgs-spring-boot-oss-autoconfigure Add configuration property to dgs spring graphql integration
kailyak
force-pushed
the
disable-sdl-comments-in-executable-schema
branch
from
ad8ab0d
to
4449ea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Added configuration option to toggle showing graphql SDL comments in introspection query results.
This feature is only on spring-graphql version of dgs-framework.
By default, SDL comments are shown but are configurable in SchemaOptions.
Descriptions: https://spec.graphql.org/June2018/#sec-Descriptions
SDL Comments: https://spec.graphql.org/June2018/#sec-Comments
Config option:
dgs.graphql.introspection.show-sdl-comments: BooleanIssue # 1031
Testing Done
Manual testing on dgs-spring-graphql sample app via toggling feature and running introspection query, added code tests.