Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring Boot 3.3 #1920

Merged
merged 6 commits into from
May 31, 2024
Merged

Upgrade to Spring Boot 3.3 #1920

merged 6 commits into from
May 31, 2024

Conversation

paulbakker
Copy link
Collaborator

Pull Request type

  • Bugfix
  • [x ] Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Upgrade to Spring Boot 3.3, which comes with graphql-java 22 and federation 5.0.0.

Copy link
Contributor

@Emily Emily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the main change ends up being the async preparsed document provider? I think this lgtm assuming the test is fixed

@paulbakker
Copy link
Collaborator Author

For release notes:

@@ -178,6 +179,7 @@ class ErrorsTest {
}

@Test
@Disabled("Broken by Jackson 2.17 https://github.com/FasterXML/jackson-databind/issues/4508")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a workaround in that linked issue that we could apply instead:

FasterXML/jackson-databind#4508 (comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilink From what I understand from the issue is that the workaround is for the Jackson folks to do, it's not something we can do as a user of Jackson.

@paulbakker paulbakker merged commit f9382bf into master May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants