Update Persistent Corpses plugin #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows limited character data (doesn't run PopulateImportantCharacterInfo hook etc...) on ragdoll.
impulsh
requested changes
Jul 28, 2021
Comment on lines
+168
to
+172
| -- remove player from netvars, we don't need to show any of the players data past death | ||
| entity:SetNetVar("player", nil) | ||
| -- we will show the characters data though | ||
| entity:SetNetVar("character", client:GetCharacter():GetID()) | ||
|
|
There was a problem hiding this comment.
You're still accessing the player via GetPlayer so there's no need to add this. Changing fairly core net vars like player should be avoided anyway due to potential breakages of other plugins/schemas that rely on it
Comment on lines
+238
to
+246
| local injure = panel:GetRow("injureText") | ||
|
|
||
| if (!injure) then | ||
| injure = panel:AddRowAfter("name", "injureText") | ||
| end | ||
|
|
||
| injure:SetText(L("injMajor")) | ||
| injure:SetBackgroundColor(Color(192, 57, 43)) | ||
| injure:SizeToContents() |
There was a problem hiding this comment.
PopulateImportantCharacterInfo already does this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V1 - Shows limited character data (doesn't run PopulateImportantCharacterInfo hook etc...) on ragdoll.
V2 - Runs PopulateImportantCharacterInfo hook, shows all character info (probably)