Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests For Windows #100

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Add Tests For Windows #100

merged 4 commits into from
Aug 3, 2023

Conversation

milwad-dev
Copy link
Contributor

@milwad-dev milwad-dev commented Jul 31, 2023 •
edited
Loading

2023-08-01_2-19-21

Coverage is 100%, but just WindowManager can't write tests because didn't return anything

@milwad-dev milwad-dev marked this pull request as draft July 31, 2023 22:19
@pari-sadegh-80
Copy link

Are you a member of NativePHP?

@milwad-dev
Copy link
Contributor Author

milwad-dev commented Jul 31, 2023 •
edited
Loading

No

@milwad-dev milwad-dev marked this pull request as ready for review July 31, 2023 22:50
@milwad-dev
Copy link
Contributor Author

@mpociot
The workflow errors are about the guzzlehttp, we talked about this before!

@mpociot mpociot merged commit cee8899 into NativePHP:main Aug 3, 2023
1 of 9 checks passed
@mpociot
Copy link
Member

mpociot commented Aug 3, 2023

Thank you!

@milwad-dev milwad-dev deleted the add-tests-for-windows branch August 4, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milwad-dev @pari-sadegh-80 @mpociot