Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use named tuples for Subject and AnalysisHit #87

Merged
merged 5 commits into from
Apr 4, 2018
Merged

Conversation

osma
Copy link
Member

@osma osma commented Apr 4, 2018

No description provided.

@osma osma added this to the v0.17 milestone Apr 4, 2018
@coveralls
Copy link

coveralls commented Apr 4, 2018

Coverage Status

Coverage increased (+0.06%) to 95.398% when pulling edbeae8 on namedtuple into dc37e4f on master.

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #87 into master will increase coverage by 0.05%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   95.34%   95.39%   +0.05%     
==========================================
  Files          29       29              
  Lines        1138     1130       -8     
==========================================
- Hits         1085     1078       -7     
+ Misses         53       52       -1
Impacted Files Coverage Δ
annif/backend/tfidf.py 100% <ø> (ø) ⬆️
annif/rest.py 33.33% <0%> (ø) ⬆️
annif/backend/http.py 100% <100%> (ø) ⬆️
annif/project.py 93.38% <100%> (ø) ⬆️
annif/hit.py 100% <100%> (+14.28%) ⬆️
annif/backend/dummy.py 100% <100%> (ø) ⬆️
annif/corpus/subject.py 82.05% <75%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc37e4f...50f5aa4. Read the comment docs.

@osma osma merged commit b12da8f into master Apr 4, 2018
@osma osma deleted the namedtuple branch April 5, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants