Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sklearn TfidfVectorizer instead of gensim dictionary and tf-idf model. Fixes #81 #84

Merged
merged 2 commits into from
Apr 3, 2018

Conversation

osma
Copy link
Member

@osma osma commented Apr 3, 2018

No description provided.

@osma osma added this to the v0.16 milestone Apr 3, 2018
@codecov
Copy link

codecov bot commented Apr 3, 2018

Codecov Report

Merging #84 into master will increase coverage by 0.16%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   95.17%   95.34%   +0.16%     
==========================================
  Files          29       29              
  Lines        1161     1138      -23     
==========================================
- Hits         1105     1085      -20     
+ Misses         56       53       -3
Impacted Files Coverage Δ
annif/corpus/subject.py 83.33% <ø> (-2.67%) ⬇️
tests/test_cli.py 100% <100%> (ø) ⬆️
tests/test_backend_tfidf.py 100% <100%> (ø) ⬆️
annif/util.py 100% <100%> (ø) ⬆️
annif/corpus/__init__.py 100% <100%> (ø) ⬆️
annif/backend/tfidf.py 100% <100%> (ø) ⬆️
annif/project.py 93.38% <76.92%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c272acf...bdeec43. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 95.347% when pulling 49ca399 on sklearn-vectorizer into c272acf on master.

@coveralls
Copy link

coveralls commented Apr 3, 2018

Coverage Status

Coverage increased (+0.2%) to 95.343% when pulling bdeec43 on sklearn-vectorizer into c272acf on master.

@osma osma merged commit 8b5582c into master Apr 3, 2018
@osma osma deleted the sklearn-vectorizer branch May 3, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants