Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move feature extraction from TF-IDF backend to project. Fixes #80 #83

Merged
merged 9 commits into from
Mar 29, 2018

Conversation

osma
Copy link
Member

@osma osma commented Mar 29, 2018

No description provided.

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #83 into master will decrease coverage by 1.51%.
The diff coverage is 85.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   96.69%   95.17%   -1.52%     
==========================================
  Files          28       29       +1     
  Lines        1149     1161      +12     
==========================================
- Hits         1111     1105       -6     
- Misses         38       56      +18
Impacted Files Coverage Δ
annif/backend/tfidf.py 100% <100%> (ø) ⬆️
tests/test_backend_tfidf.py 100% <100%> (ø) ⬆️
annif/util.py 100% <100%> (ø)
annif/corpus/__init__.py 100% <100%> (ø) ⬆️
tests/test_cli.py 100% <100%> (ø) ⬆️
annif/corpus/subject.py 86% <78.12%> (-14%) ⬇️
annif/project.py 91.72% <79.24%> (-8.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba04aa4...dd2b7e5. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 29, 2018

Coverage Status

Coverage decreased (-1.5%) to 95.177% when pulling dd2b7e5 on project-feature-extraction into ba04aa4 on master.

@osma osma merged commit c272acf into master Mar 29, 2018
@osma osma deleted the project-feature-extraction branch May 3, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants