Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using pytest-flake8 plugin #650

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Nov 25, 2022

Closes #599.

Unpins flake8. On my laptop version 5.0.4 get installed, while 6.0.0 was released two days ago.

In the CI/CD pipeline I added flake8 step that both installs flake8 from PyPI with pip and runs it. There version 6.0.0 get installed. I did not find a good GH Action for flake8 (an official one or any which seemed otherwise reputable), so it can be better to install it this way.

The mismatch of the versions is unfortunate, but makes no difference at this time.

Also I'm thinking that it might be a good idea to switch installing also isort and Black from PyPI (instead of using the GH Actions), and using Poetry for that (regular dependencies can be omitted by poetry install --only dev).

@juhoinkinen juhoinkinen added this to the 0.60 milestone Nov 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 99.54% // Head: 99.55% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2e812ec) compared to base (1a58116).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   99.54%   99.55%           
=======================================
  Files          87       87           
  Lines        5988     6004   +16     
=======================================
+ Hits         5961     5977   +16     
  Misses         27       27           
Impacted Files Coverage Δ
annif/backend/http.py 100.00% <0.00%> (ø)
tests/test_backend_http.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juhoinkinen juhoinkinen marked this pull request as ready for review November 25, 2022 13:26
@osma
Copy link
Member

osma commented Nov 25, 2022

Looks very good!

Also I'm thinking that it might be a good idea to switch installing also isort and Black from PyPI (instead of using the GH Actions), and using Poetry for that (regular dependencies can be omitted by poetry install --only dev).

I think that sounds like a good idea! Would it make sense to do this change already in this PR, or a new one after this has been merged?

@juhoinkinen
Copy link
Member Author

Looks very good!

Also I'm thinking that it might be a good idea to switch installing also isort and Black from PyPI (instead of using the GH Actions), and using Poetry for that (regular dependencies can be omitted by poetry install --only dev).

I think that sounds like a good idea! Would it make sense to do this change already in this PR, or a new one after this has been merged?

Better to make a new PR for that think, it might need some experimenting to make it work...

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally on my laptop. Works fine, although running poetry lock and poetry install --all-extras didn't remove pytest-flake8 so I removed it manually using pip.

But as the pytest option --flake8 was removed in this PR, it won't be used by pytest anyway, so even if the package remains installed it shouldn't do any harm.

@juhoinkinen juhoinkinen merged commit 05bb64d into master Nov 25, 2022
@juhoinkinen juhoinkinen deleted the issue599-avoid-using-pytest-flake8 branch November 25, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using pytest-flake8, run flake8 separately instead
2 participants