Use fulltext corpus in MLLM tests which is much faster #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 84 84
Lines 5565 5568 +3
=======================================
+ Hits 5536 5539 +3
Misses 29 29
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the unit tests weren't making use of the small fulltext document corpus included in the test suite (tests/corpora/archaeology/fulltext/). In this PR, I've added a fixture to use it and switched the MLLM tests to use it instead of document_corpus. This speeds up the MLLM tests by a lot (24s -> 2s on my laptop).