Issue3 #25
Merged
Issue3 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osma
approved these changes
Oct 9, 2017
annif/annif.py
Outdated
| print(p) | ||
|
|
||
| print(projects) | ||
| report = cat.indices() # This queries different indices and returns |
There was a problem hiding this comment.
Is this really necessary? The result seems to be just thrown away.
There was a problem hiding this comment.
Not really, same thing applies here. I'll do another commit to remove these before merging.
annif/annif.py
Outdated
| for p in projects: | ||
| print(p) | ||
|
|
||
| print(projects) |
There was a problem hiding this comment.
This is redundant after the previous for loop
There was a problem hiding this comment.
Oops, true. I tried different ways to present the results when configuring tests. This I'll remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation for create-project and drop-project.