-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on changing vocab for trained models #326
Comments
This is a good idea. However, if we implemented #274 first then the problem would be at least partly mitigated. |
As Osma pointed today, a similar problem probably arises also when projects with different vocabularies are combined to an ensemble model. |
I think this can be closed, because since #614 the argument to the load-vocabulary command is a vocabulary ID, not a project ID, so it is a less surprise that the operation affects (or can affect) multiple projects. Also since #274 it could be possible to "undo" loading a wrong vocabulary, because the original URIs are retained in the internal vocabulary, so just loading the original vocabulary back could reset the situation. (Disclaimer: I'm not sure about this.) |
When several projects share a vocabulary, it is easy to unintentionally change the vocab for all them, when one means to change the vocab for only one project. Especially when some of the projects are already trained, this can be a problem, because changing the vocab then messes the models (is this always the case?). For example:
Annif could give a warning when reloading a vocabulary, which could list all the projects that share the vocabulary, or at least all the projects that have been already trained using the vocabulary that now changes. Or there could even be a confirmation prompt for the latter projects case.
The text was updated successfully, but these errors were encountered: