Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain subject IDs when loading vocabulary over existing one #274

Closed
osma opened this issue May 7, 2019 · 0 comments · Fixed by #383
Closed

Retain subject IDs when loading vocabulary over existing one #274

osma opened this issue May 7, 2019 · 0 comments · Fixed by #383
Assignees
Milestone

Comments

@osma
Copy link
Member

osma commented May 7, 2019

Currently if you load a new version of a vocabulary over an existing one, what likely happens is that the integer subject IDs used internally within Annif will change. This will cause mismatches with backends that use the subject IDs (e.g. tfidf, fasttext, vw_multi) within their models, so you have to train them again.

Instead we could try to match URIs in the new vocabulary with old subject IDs and reuse them as much as possible. Then at least loading a vocabulary with additional concepts would not break existing models. If concepts have disappeared from the new version of the vocabulary, they should be marked as nonexistent and filtered from suggestion results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants