Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastText backend fails when encountering an unknown subject URI #134

Closed
osma opened this issue May 21, 2018 · 0 comments
Closed

fastText backend fails when encountering an unknown subject URI #134

osma opened this issue May 21, 2018 · 0 comments
Labels

Comments

@osma
Copy link
Member

osma commented May 21, 2018

Traceback:

Backend fasttext: creating fastText training file from documents
Traceback (most recent call last):
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/bin/annif", line 11, in <module>
    load_entry_point('Annif', 'console_scripts', 'annif')()
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/flask/cli.py", line 557, in main
    return super(FlaskGroup, self).main(*args, **kwargs)
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/flask/cli.py", line 412, in decorator
    return __ctx.invoke(f, *args, **kwargs)
  File "/home/oisuomin/.local/share/virtualenvs/Annif-OYFUWV2R/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/oisuomin/git/Annif/annif/cli.py", line 122, in run_loaddocs
    proj.load_documents(documents)
  File "/home/oisuomin/git/Annif/annif/project.py", line 222, in load_documents
    self._load_documents_to_backends(documents, subjects)
  File "/home/oisuomin/git/Annif/annif/project.py", line 202, in _load_documents_to_backends
    backend.load_documents(documents, project=self)
  File "/home/oisuomin/git/Annif/annif/backend/fasttext.py", line 124, in load_documents
    self._create_train_file_from_documents(documents, project)
  File "/home/oisuomin/git/Annif/annif/backend/fasttext.py", line 107, in _create_train_file_from_documents
    method=self._write_train_file)
  File "/home/oisuomin/git/Annif/annif/util.py", line 19, in atomic_save
    method(obj, tempfilename)
  File "/home/oisuomin/git/Annif/annif/backend/fasttext.py", line 66, in _write_train_file
    labels = [cls._id_to_label(sid) for sid in subject_ids]
  File "/home/oisuomin/git/Annif/annif/backend/fasttext.py", line 66, in <listcomp>
    labels = [cls._id_to_label(sid) for sid in subject_ids]
  File "/home/oisuomin/git/Annif/annif/backend/fasttext.py", line 55, in _id_to_label
    return "__label__{:d}".format(subject_id)
TypeError: non-empty format string passed to object.__format__

Probably subject_id here is None, because the TSV document mentions a subject URI that is not in the SubjectIndex.

@osma osma added the bug label May 21, 2018
@osma osma closed this as completed in ddc4f3d May 21, 2018
osma added a commit that referenced this issue May 21, 2018
Handle documents unknown subject URIs in fastText backend. Fixes #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant