Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style display:none in initializer prevents playback in Firefox #3

Open
aguywithanidea opened this issue Mar 3, 2017 · 12 comments
Open

Comments

@aguywithanidea
Copy link

It has been reported that in Firefox browsers, because the init function sets the display style to none (see line 83), playback will never be enabled because the ready event will never be received.

@mkommar
Copy link

mkommar commented Apr 12, 2017

Commenting out display: none line for me actually triggers the Player.playerReady() function.

@mkommar
Copy link

mkommar commented Apr 12, 2017

In addition, in Firefox, there is an exception
TypeError
"Argument 2 of EventTarget.addEventListener is not an object."
"Player.playerReady@http:https://api.napster.com/v1.1/player/player.js:1:3446playerReady@http:https://api.napster.com/v1.1/player/player.js:1:24@http:https://api.napster.com/v1.1/player/index.html?apikey=MTM2Zjc1OWMtZjIyYS00NjlkLTljYzItMTA2NDEyNDgyZTAy:0:22"
image

@mkommar
Copy link

mkommar commented Apr 14, 2017

Seems to be working now after I restarted Firefox.

@aguywithanidea
Copy link
Author

Thanks for the feedback @mkommar. We're in progress of updating the SDK to remove the dependency on Flash for track playback (HTML5 Audio - yeah baby!)

We will fix this bug in the example app when we make the player update.

@mfitzhenry
Copy link

@aguywithanidea - Any idea ETA on when the HTML5 audio version will be released?

@aguywithanidea
Copy link
Author

We're currently hoping to have this released in early August. We will keep you posted :)

@mfitzhenry
Copy link

@aguywithanidea any update on the new release timing?

@afonsorp
Copy link

afonsorp commented Oct 13, 2017

Hi!
@aguywithanidea, sorry to insist. But can you give us an update on the HTML5 audio version?

@mfitzhenry
Copy link

@aguywithanidea - Here is my every few month check in...:) Any update on the new release? Eagerly awaiting. Happy Holidays!

@lolpack
Copy link

lolpack commented Dec 22, 2017

Hi @mfitzhenry thanks for checking in on this. We are working on this now. I will update this thread when we have the release date finalized.

@eltmon
Copy link

eltmon commented Mar 13, 2018

Any update, I'm eagerly awaiting for html 5 support as well!

@eltmon
Copy link

eltmon commented Jun 22, 2018

Any updates on the html5 release? Anxiously awaiting! Maybe can you offer an early beta we can start working with?

BreaGaudioso pushed a commit to BreaGaudioso/napster.js that referenced this issue Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants