fix(deploy): pass jsonSchema #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
approved these changes
Jun 26, 2024
TBonnin
approved these changes
Jun 26, 2024
| // sync_type: sync.sync_type as SyncType, | ||
| type: sync.type as any, | ||
| sync_type: sync.sync_type, | ||
| type: sync.type, |
There was a problem hiding this comment.
what's the difference between sync_type and type and why it is uncommented here and not below?
There was a problem hiding this comment.
- type is action or sync
- sync_type is full or incremental
it was commented by mistake, but it's not really used in the backend. Those two names are confusing but yeah legacy stuff
| @@ -365,7 +358,7 @@ class DeployService { | |||
| return null; | |||
| } | |||
|
|
|||
| return { flowConfigs: postData, postConnectionScriptsByProvider, jsonSchema: jsonSchema }; | |||
| return { flowConfigs: postData, postConnectionScriptsByProvider, jsonSchema: JSON.parse(jsonSchema) as JSONSchema7 }; | |||
There was a problem hiding this comment.
parsing can fail. are we ok throwing here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Contributes to https://linear.app/nango/issue/NAN-1261/pass-json-schema-to-runner
Pass new property JsonSchema when deploying
It's not used or stored yet.
Added one test that assert the
package()is correct and one integration test that checks deploy works.Small rework of
deployfunction to remove params passed as referenceRevert the storage of raw
undefinedin model schemaIt's not compatible with JSON so it's now stored as a string instead (but still displayed correctly)
Tests
nango deploy devit shouldn't change anythingnode packages/cli/dist/index.js deploy devit shouldn't break anything :D