fix(integrations): update base_url for gong-oauth #1770

hassan254-prog · 2024-03-01T09:37:06Z

Describe your changes

Gong recently made changes to their API. Gong-oauth now uses api_base_url_for_customer, which varies for each customer, as its base_url for proxy requests. This parameter is returned in the response of generate-customer-token when exchanging code for an access token.

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

I added tests, otherwise the reason is:
I added observability, otherwise the reason is:
I added analytics, otherwise the reason is:

khaliqgant · 2024-03-05T06:44:00Z

@hassan254-prog should this still be in draft?

hassan254-prog · 2024-03-05T07:34:29Z

Robin had suggested I place it in draft just in case there is more work to it.

tconlin · 2024-03-11T15:38:19Z

@hassan254-prog Will this automatically work for all customers? Will there ever be a situation where a sync will fail because a customer does not yet have api_base_url_for_customer defined?

hassan254-prog · 2024-03-11T19:13:39Z

@tconlin , according to this thread, whenever the code is exchanged for an access token during authorization, as part of data residency support, the api_base_url_for_customer will be generated and returned in response. Have you gotten the chance to test this?

tconlin · 2024-03-14T21:57:08Z

@rguldener Can we bring this out of drafts?

rguldener · 2024-03-15T10:43:09Z

@rguldener Can we bring this out of drafts?

Sure! I only suggested draft initially because there might have been more work needed. Feel free to move this forward.

bastienbeurier · 2024-03-15T15:54:10Z

packages/shared/providers.yaml

@@ -753,7 +755,7 @@ gong-oauth:
 disable_pkce: true
 token_request_auth_method: basic
 proxy:
- base_url: https://api.gong.io
+ base_url: ${connectionConfig.api_base_url_for_customer}


I'm concerned this will break existing connections that don't have the api_base_url_for_customer field populated in the connection config.

Is there a way to fall back to https://api.gong.io?

Would something like ${connectionConfig.api_base_url_for_customer || 'https://api.gong.io} work?

@bastienbeurier , I will do some test on this and see if the platform will handle such case. Incase of any changes to the platform, I will add them to this pull request. Thank you.

For reference, I checked that no one was using Gong in prod at the moment.

TBonnin

is it still the case that nobody uses gong, because that's a breaking change. otherwise look good to me

hassan254-prog · 2024-07-12T14:17:29Z

@TBonnin , I don't have much context on this, but the last time we checked with @bastienbeurier , it was okay to merge. Could you please check if the number has changed before merging? Thank you!

TBonnin · 2024-07-12T20:11:32Z

@TBonnin , I don't have much context on this, but the last time we checked with @bastienbeurier , it was okay to merge. Could you please check if the number has changed before merging? Thank you!

I see 12 accounts using gong-auth in prod environments (5 have connections). We are gonna need a strategy so we don't break their integrations cc @bastienbeurier for visibility

bastienbeurier · 2024-07-22T14:01:46Z

@TBonnin , I don't have much context on this, but the last time we checked with @bastienbeurier , it was okay to merge. Could you please check if the number has changed before merging? Thank you!

I see 12 accounts using gong-auth in prod environments (5 have connections). We are gonna need a strategy so we don't break their integrations cc @bastienbeurier for visibility

I also see production usage for it.

@hassan254-prog @TBonnin @khaliqgant Is there a way to have a fallback system to avoid a breaking change?

Something like ${connectionConfig.api_base_url_for_customer || 'https://api.gong.io'}

TBonnin · 2024-07-24T13:21:10Z

Something like ${connectionConfig.api_base_url_for_customer || 'https://api.gong.io'}

I don't think we support this syntax in providers.yaml @khaliqgant might be able to confirm.

Could we populate the connection config for existing gong-auth connections with the default url? Might require synchronization between doing that and releasing this change though.

khaliqgant · 2024-07-25T03:11:41Z

Something like ${connectionConfig.api_base_url_for_customer || 'https://api.gong.io'}

I don't think we support this syntax in providers.yaml @khaliqgant might be able to confirm.

No we don't but the idea was brought up in the past but decided against it to not have too much code like syntax in yaml which might prove difficult to maintain.

gitguardian · 2024-08-02T22:10:01Z

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
8205899	Triggered	Generic Password	`2bb094f`	docker-compose.yaml	View secret
8205899	Triggered	Generic Password	`2bb094f`	dev/docker-compose.dev.yaml	View secret
8205899	Triggered	Generic Password	`2bb094f`	dev/docker-compose.dev.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

packages/shared/providers.yaml

khaliqgant · 2024-08-08T12:25:46Z

packages/shared/providers.yaml

@@ -1124,7 +1126,7 @@ gong-oauth:
 disable_pkce: true
 token_request_auth_method: basic
 proxy:
- base_url: https://api.gong.io
+ base_url: ${connectionConfig.api_base_url_for_customer} || https://api.gong.io


@bodinsamuel unless I missed something this won’t work without #1873?

ah wasn't aware of this, thanks 👌🏻

## Describe your changes Continuing from this, #1770 (comment). We need to have a fallback incase `api_base_url_for_customer` field is not populated in the connection configuration. I have also added a unit test for this.. --------- Co-authored-by: Khaliq <[email protected]>

Gong API changes

b8ddcfa

bastienbeurier approved these changes Mar 1, 2024

View reviewed changes

Merge branch 'master' into gong-api-support

4c43f76

tconlin added 2 commits March 11, 2024 16:27

Merge branch 'master' into gong-api-support

7d38734

Merge branch 'master' into gong-api-support

531218b

Merge branch 'master' into gong-api-support

2f53466

tconlin marked this pull request as ready for review March 15, 2024 15:49

tconlin requested a review from bastienbeurier March 15, 2024 15:49

bastienbeurier requested changes Mar 15, 2024

View reviewed changes

review

43841d5

hassan254-prog requested a review from bastienbeurier March 18, 2024 21:30

hassan254-prog mentioned this pull request Mar 18, 2024

feat(proxy): add fallback to proxy base_url #1873

Merged

revert proxy base_url

a7580f4

hassan254-prog requested review from bodinsamuel, TBonnin and khaliqgant July 12, 2024 08:54

TBonnin approved these changes Jul 12, 2024

View reviewed changes

TBonnin self-requested a review July 12, 2024 20:09

Merge branch 'NangoHQ:master' into gong-api-support

2bb094f

add fallback base_url

f312927

hassan254-prog changed the title ~~feat(integrations):api support for gong-oauth~~ fix(integrations): update base_url for gong-oauth Aug 2, 2024

bodinsamuel approved these changes Aug 5, 2024

View reviewed changes

packages/shared/providers.yaml Show resolved Hide resolved

bodinsamuel enabled auto-merge (squash) August 5, 2024 12:41

bodinsamuel added 2 commits August 5, 2024 14:41

Merge branch 'master' into gong-api-support

9959efe

Merge branch 'master' into gong-api-support

66eb6f4

bodinsamuel disabled auto-merge August 8, 2024 08:54

bodinsamuel merged commit f67df26 into NangoHQ:master Aug 8, 2024
19 of 22 checks passed

khaliqgant reviewed Aug 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(integrations): update base_url for gong-oauth #1770

fix(integrations): update base_url for gong-oauth #1770

hassan254-prog commented Mar 1, 2024

khaliqgant commented Mar 5, 2024

hassan254-prog commented Mar 5, 2024

tconlin commented Mar 11, 2024

hassan254-prog commented Mar 11, 2024

tconlin commented Mar 14, 2024

rguldener commented Mar 15, 2024

bastienbeurier Mar 15, 2024 •

edited

Loading

hassan254-prog Mar 15, 2024

bastienbeurier May 28, 2024

TBonnin left a comment

hassan254-prog commented Jul 12, 2024

TBonnin commented Jul 12, 2024 •

edited

Loading

bastienbeurier commented Jul 22, 2024

TBonnin commented Jul 24, 2024 •

edited

Loading

khaliqgant commented Jul 25, 2024 •

edited

Loading

gitguardian bot commented Aug 2, 2024 •

edited

Loading

khaliqgant Aug 8, 2024

bodinsamuel Aug 9, 2024

fix(integrations): update base_url for gong-oauth #1770

fix(integrations): update base_url for gong-oauth #1770

Conversation

hassan254-prog commented Mar 1, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

khaliqgant commented Mar 5, 2024

hassan254-prog commented Mar 5, 2024

tconlin commented Mar 11, 2024

hassan254-prog commented Mar 11, 2024

tconlin commented Mar 14, 2024

rguldener commented Mar 15, 2024

bastienbeurier Mar 15, 2024 • edited Loading

Choose a reason for hiding this comment

hassan254-prog Mar 15, 2024

Choose a reason for hiding this comment

bastienbeurier May 28, 2024

Choose a reason for hiding this comment

TBonnin left a comment

Choose a reason for hiding this comment

hassan254-prog commented Jul 12, 2024

TBonnin commented Jul 12, 2024 • edited Loading

bastienbeurier commented Jul 22, 2024

TBonnin commented Jul 24, 2024 • edited Loading

khaliqgant commented Jul 25, 2024 • edited Loading

gitguardian bot commented Aug 2, 2024 • edited Loading

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

khaliqgant Aug 8, 2024

Choose a reason for hiding this comment

bodinsamuel Aug 9, 2024

Choose a reason for hiding this comment

bastienbeurier Mar 15, 2024 •

edited

Loading

TBonnin commented Jul 12, 2024 •

edited

Loading

TBonnin commented Jul 24, 2024 •

edited

Loading

khaliqgant commented Jul 25, 2024 •

edited

Loading

gitguardian bot commented Aug 2, 2024 •

edited

Loading