Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string_test.py errors on Spark 4.0 #11247

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mythrocks
Copy link
Collaborator

Fixes #11030.

This commit skips the tests pertaining to the following operations on Apache Spark 4.0:

  1. Column.endswith()
  2. substring_index()

In both cases, the CPU version of Apache Spark 4.0 seems to cause exceptions, unrelated to the Spark RAPIDS plugin. See:

  1. https://issues.apache.org/jira/browse/SPARK-48989
  2. https://issues.apache.org/jira/browse/SPARK-48995

Fixes NVIDIA#11030.

This commit skips the tests pertaining to the following operations
on Apache Spark 4.0:

1. Column.endswith()
2. substring_index()

In both cases, the CPU version of Apache Spark 4.0 seems to cause
exceptions, unrelated to the Spark RAPIDS plugin. See:

1. https://issues.apache.org/jira/browse/SPARK-48989
2. https://issues.apache.org/jira/browse/SPARK-48995

Signed-off-by: MithunR <[email protected]>
@mythrocks mythrocks added the audit_4.0.0 Audit related tasks for 4.0.0 label Jul 24, 2024
@mythrocks mythrocks self-assigned this Jul 24, 2024
@mythrocks mythrocks requested a review from razajafri July 24, 2024 22:05
@mythrocks
Copy link
Collaborator Author

Pinging @razajafri for a review. The Apache Spark JIRAs associated with the skipped tests are listed in the description.

@razajafri
Copy link
Collaborator

I was able to repro 2. pretty consistently.

@razajafri
Copy link
Collaborator

build

@razajafri razajafri merged commit 273af38 into NVIDIA:branch-24.08 Jul 25, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit_4.0.0 Audit related tasks for 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests failures in string_test.py
2 participants