Unified platform handling and fetching of operator score files #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616.
This PR fixes the below issues related to platform argument:
Major Changes:
Platform.scala
:Platform.scala
outside the profiler package for shared use.PlatformNames
to store platform strings as constants.PlatformFactory
to createPlatform
instances based on platform string values.Addresses #1
createInstance()
to get platform instance.Addresses #2
PluginTypeChecker.scala
:getOperatorScoreFile()
defined inPlatform.scala
for dynamic filename generation of operator score files.Addresses #3
Follow Up:
PlatformNames
class.