Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix alignment in dyn_smem example #381

Merged

Conversation

gevtushenko
Copy link
Collaborator

The following PR introduces an example with unaligned memory accesses. This PR fixes this issue.

@gevtushenko
Copy link
Collaborator Author

@MatthiasKohl, thank you for your PR! Please, check if you agree with the changes.

@MatthiasKohl
Copy link
Contributor

Yes, this is something I missed in my PR. Thank you for fixing this!

@alliepiper alliepiper added the only: docs Documentation changes only. Doesn't need code CI. label Oct 6, 2021
@alliepiper alliepiper added this to the 1.15.0 milestone Oct 6, 2021
@alliepiper alliepiper added type: bug: functional Does not work as intended. and removed only: docs Documentation changes only. Doesn't need code CI. labels Oct 6, 2021
@alliepiper
Copy link
Collaborator

This looks good to me. Can you create a thrust PR and run this through gpuCI before merging?

@alliepiper
Copy link
Collaborator

@senior-zero Looks like this just needs gpuCI testing. I'll start prepping the 1.15 release next week, so let's get those started or update the milestone.

@alliepiper alliepiper added the P1: should have Necessary, but not critical. label Oct 14, 2021
@gevtushenko gevtushenko removed this from the 1.15.0 milestone Oct 15, 2021
@gevtushenko gevtushenko changed the title Fix alignment in dyn_smem example Draft - fix alignment in dyn_smem example Oct 15, 2021
@alliepiper alliepiper added this to the 1.16.0 milestone Oct 26, 2021
@alliepiper alliepiper modified the milestones: 1.16.0, 1.17.0 Feb 7, 2022
@alliepiper alliepiper added the only: gpuci Changes to gpuCI only. Doesn't need internal NVIDIA CI. label Feb 7, 2022
@alliepiper alliepiper force-pushed the main-bug/github/dyn_smem_example branch from e2240f6 to 92effeb Compare February 7, 2022 20:51
alliepiper added a commit to alliepiper/thrust that referenced this pull request Feb 7, 2022
@alliepiper alliepiper changed the title Draft - fix alignment in dyn_smem example Fix alignment in dyn_smem example Feb 7, 2022
@alliepiper alliepiper assigned alliepiper and unassigned gevtushenko Feb 7, 2022
@alliepiper alliepiper modified the milestones: 1.17.0, 1.16.0 Feb 7, 2022
@alliepiper
Copy link
Collaborator

gpuCI: NVIDIA/thrust#1613

@alliepiper alliepiper added the testing: gpuCI in progress Started gpuCI testing. label Feb 7, 2022
@alliepiper alliepiper merged commit cba758a into NVIDIA:main Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
only: gpuci Changes to gpuCI only. Doesn't need internal NVIDIA CI. P1: should have Necessary, but not critical. testing: gpuCI in progress Started gpuCI testing. type: bug: functional Does not work as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants