This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 447
Fix alignment in dyn_smem example #381
Merged
alliepiper
merged 1 commit into
NVIDIA:main
from
gevtushenko:main-bug/github/dyn_smem_example
Feb 8, 2022
Merged
Fix alignment in dyn_smem example #381
alliepiper
merged 1 commit into
NVIDIA:main
from
gevtushenko:main-bug/github/dyn_smem_example
Feb 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MatthiasKohl, thank you for your PR! Please, check if you agree with the changes. |
Yes, this is something I missed in my PR. Thank you for fixing this! |
alliepiper
added
type: bug: functional
Does not work as intended.
and removed
only: docs
Documentation changes only. Doesn't need code CI.
labels
Oct 6, 2021
alliepiper
approved these changes
Oct 6, 2021
This looks good to me. Can you create a thrust PR and run this through gpuCI before merging? |
@senior-zero Looks like this just needs gpuCI testing. I'll start prepping the 1.15 release next week, so let's get those started or update the milestone. |
gevtushenko
changed the title
Fix alignment in dyn_smem example
Draft - fix alignment in dyn_smem example
Oct 15, 2021
alliepiper
added
the
only: gpuci
Changes to gpuCI only. Doesn't need internal NVIDIA CI.
label
Feb 7, 2022
alliepiper
force-pushed
the
main-bug/github/dyn_smem_example
branch
from
February 7, 2022 20:51
e2240f6
to
92effeb
Compare
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Feb 7, 2022
alliepiper
changed the title
Draft - fix alignment in dyn_smem example
Fix alignment in dyn_smem example
Feb 7, 2022
gpuCI: NVIDIA/thrust#1613 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
only: gpuci
Changes to gpuCI only. Doesn't need internal NVIDIA CI.
P1: should have
Necessary, but not critical.
testing: gpuCI in progress
Started gpuCI testing.
type: bug: functional
Does not work as intended.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR introduces an example with unaligned memory accesses. This PR fixes this issue.