Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++11 support of recently added tests #651

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Fix C++11 support of recently added tests #651

merged 4 commits into from
Nov 3, 2023

Conversation

ahendriksen
Copy link
Contributor

Description

closes #650

  • Skip the generic cp_async_bulk tests pre-c++14.
  • Skip static_asserts in some private functions used in memcpy_async when if constexpr is not available.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ahendriksen
Fix static_assert issue in memcpy_async
6b685bf
@ahendriksen
Skip cp_async_bulk* tests pre-C++14
cbbe848 
The tests themselves use C++14 constexpr features. The library code is
still tested through:

PASS: libcu++ :: cuda/barrier/cp_async_bulk_ptx_compiles.pass.cpp (6 of 9)
PASS: libcu++ :: cuda/barrier/cp_async_bulk_feature_test.pass.cpp (7 of 9)
PASS: libcu++ :: cuda/barrier/cp_async_bulk.pass.cpp (8 of 9)
PASS: libcu++ :: cuda/barrier/cp_async_bulk_tensor.pass.cpp (9 of 9)
@ahendriksen ahendriksen requested review from a team as code owners November 2, 2023 15:21
@ahendriksen ahendriksen requested review from miscco and wmaxey and removed request for a team November 2, 2023 15:21
@jrhemstad jrhemstad added the backport branch/2.3.x For backporting to the 2.3.x release branch label Nov 2, 2023
@miscco miscco merged commit abe6d1c into NVIDIA:main Nov 3, 2023
515 checks passed
@miscco
Copy link
Collaborator

miscco commented Nov 3, 2023

/backport

1 similar comment
@jrhemstad
Copy link
Collaborator

/backport

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

@jrhemstad
Copy link
Collaborator

/backport

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Successfully created backport PR for branch/2.3.x:

@github-actions github-actions bot mentioned this pull request Nov 3, 2023
Merged
@jrhemstad jrhemstad removed the backport branch/2.3.x For backporting to the 2.3.x release branch label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Some tests do not support C++11
3 participants
@ahendriksen @miscco @jrhemstad