Replace default, constexpr, and delete macros by original keywords #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests from external contributors require approval from a |
miscco
reviewed
Aug 21, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__utility/pair.h
Outdated
Show resolved
Hide resolved
|
/ok to test |
1 similar comment
|
/ok to test |
miscco
approved these changes
Aug 22, 2023
added 2 commits
August 22, 2023 20:24
…macros As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `default`, `constexpr`, and `delete` are supported by all targeted compilers, so the conditional support can be removed. All `_LIBCUDACXX_CONSTEXPR` macros are replaced by `constexpr`. All `_LIBCUDACXX_EQUAL_DEFAULT` macros are replaced by `= default;`. All `_LIBCUDACXX_EQUAL_DELETE` macros are replaced by `= delete;`.
168eb5f
to
b2c3cfb
Compare
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #127, code for unsupported compilation modes/platforms will be removed.
default,constexpr, anddeleteare supported by all targeted compilers so that the conditional support can be removed.All
_LIBCUDACXX_CONSTEXPRmacros are replaced byconstexpr. All_LIBCUDACXX_EQUAL_DEFAULTmacros are replaced by= default;. All_LIBCUDACXX_EQUAL_DELETEmacros are replaced by= delete;.Checklist