Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on support for exceptions. #384

Merged
merged 14 commits into from
Aug 21, 2024

Conversation

drazvan
Copy link
Collaborator

@drazvan drazvan commented Mar 6, 2024

WIP. Still needs:

  • configuration option to choose modes
  • update all existing rails to comply
  • documentation
  • tests

@drazvan drazvan self-assigned this Mar 6, 2024
@drazvan drazvan added enhancement New feature or request status: in progress Issues that are currently being worked on. labels Mar 6, 2024
@drazvan drazvan added this to the v0.9.0 milestone Mar 6, 2024
@drazvan drazvan modified the milestones: v0.8.2, v0.10.0 Apr 15, 2024
@Pouyanpi Pouyanpi force-pushed the feature/support-for-exceptions branch from 5313211 to 5e79b60 Compare June 7, 2024 11:24
Copy link
Collaborator Author

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! 👍

nemoguardrails/rails/llm/config.py Outdated Show resolved Hide resolved
examples/bots/abc/config.yml Outdated Show resolved Hide resolved
@Pouyanpi Pouyanpi force-pushed the feature/support-for-exceptions branch from a2f82fa to cb88837 Compare July 5, 2024 15:11
@Pouyanpi
Copy link
Collaborator

related issue #634

@drazvan drazvan marked this pull request as ready for review August 20, 2024 11:10
@drazvan
Copy link
Collaborator Author

drazvan commented Aug 20, 2024

@Pouyanpi : can you sort the conflicts and add a short documentation to the configuration guide. Thanks!
(and feel free to rebase so that all commits get signed)

@Pouyanpi Pouyanpi force-pushed the feature/support-for-exceptions branch from cb88837 to 7ee2fb9 Compare August 20, 2024 12:00
@Pouyanpi
Copy link
Collaborator

@drazvan, I made the changes, please have a look.

@drazvan
Copy link
Collaborator Author

drazvan commented Aug 21, 2024

Thanks @Pouyanpi. I had to fix a bug related to the stop behavior, see my commit, and tweak a bit more the docs. We need to add tests for the rest, but we'll do in a separate PR.

@drazvan drazvan merged commit 835e21c into develop Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status: in progress Issues that are currently being worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants