Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typer upgrade to 0.9 with support to 0.7 #276

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

eneadodi
Copy link
Contributor

Upgraded type related to this issue

2 lines of code changed, passed all tests as shown in screenshot:
nemoguardrails-typer-upgrade

requesting pull direct to 'develop' branch do to simplicity of task. If preferred to pull request to another branch, I'll get that done soon.

@drazvan
Copy link
Collaborator

drazvan commented Jan 29, 2024

Thanks for this @eneadodi! Can you sign the commit and force-push the branch?
https://github.com/NVIDIA/NeMo-Guardrails/blob/develop/CONTRIBUTING.md#submitting-your-work

I should be able to merge this today/tomorrow, before the 0.7.0 release.
Thanks!

@eneadodi
Copy link
Contributor Author

Hey @drazvan I think we are all set? Let me know if something failed along the way. First time (and hopefully not last) time going through this process

@drazvan drazvan self-assigned this Jan 30, 2024
@drazvan drazvan added the dependencies Pull requests that update a dependency file label Jan 30, 2024
@drazvan drazvan added this to the v0.7.0 milestone Jan 30, 2024
@drazvan drazvan merged commit cd75cec into NVIDIA:develop Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants