Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codebase with appropriate coding standards #228

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

rajveer43
Copy link
Contributor

@rajveer43 rajveer43 commented Dec 15, 2023

@drazvan now here the commit is verified. I will update all the docstrings soon in this branch.

@rajveer43 rajveer43 changed the title Updating docstrings. Update codebase with appropriate coding standards Dec 15, 2023
@rajveer43
Copy link
Contributor Author

@drazvan you can review this and let me know if any fix is required.

@drazvan drazvan self-requested a review January 11, 2024 14:03
@drazvan drazvan self-assigned this Jan 11, 2024
@drazvan drazvan added this to the v0.7.0 milestone Jan 11, 2024
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking the time to do this @rajveer43! 👍

@drazvan drazvan merged commit 6758af1 into NVIDIA:develop Jan 12, 2024
@rajveer43
Copy link
Contributor Author

Thanks again for taking the time to do this @rajveer43! 👍

there are still some left will do that in another PR!

@drazvan
Copy link
Collaborator

drazvan commented Jan 12, 2024

Yes. Soon, we should add a linter as part of the CI to check the proper formatting of all docstrings (among other things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants