Pin Rapids to 24.8 for 0.5.0 Release #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek Mahajan <[email protected]>
ayushdg
approved these changes
Oct 1, 2024
ryantwolf
approved these changes
Oct 1, 2024
Signed-off-by: Praateek Mahajan <[email protected]>
Signed-off-by: Praateek Mahajan <[email protected]>
Signed-off-by: Praateek Mahajan <[email protected]>
ryantwolf
reviewed
Oct 1, 2024
requirements/requirements.txt
Outdated
| @@ -14,7 +14,6 @@ justext==3.0.1 | |||
| lxml_html_clean | |||
| mwparserfromhell==0.6.5 | |||
| nemo_toolkit[nlp]>=1.23.0 | |||
| numpy<2 | |||
There was a problem hiding this comment.
Do you just want to have numpy without any pin instead of removing it entirely?
There was a problem hiding this comment.
Don't have opinions on when we want something to be explicitly defined here or be picked up as a dependency from one of the N packages being installed which also depend on numpy. If anything I'd say let's remove it altogether but not strongly opinionated.
ayushdg
requested changes
Oct 1, 2024
3 tasks
Signed-off-by: Praateek Mahajan <[email protected]>
ayushdg
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since our release is planned for 2nd week of October, and Rapids might do a 24.10 release by 10th Oct