Gb/solar module #92
Merged
Gb/solar module #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d convert to irradiance variables
…ntry point to run all t chunks if not provided
… the same year as the gan time index
… sup3r output to source alias name
bnb32
reviewed
Sep 15, 2022
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class Solar: |
There was a problem hiding this comment.
Thanks! feels so good to have a full day without meetings and a blank slate haha.
bnb32
reviewed
Sep 15, 2022
tests/test_solar_module.py
Outdated
| return CliRunner() | ||
|
|
||
|
|
||
| def make_cs_ratio_files(td, low_res_times, low_res_lat_lon): |
There was a problem hiding this comment.
move this to test_utils.py? Doesnt really matter though
There was a problem hiding this comment.
ah yeah that's where these things go! will do.
bnb32
approved these changes
Sep 15, 2022
|
Yeah! irrad models are my jam. This worked out great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.