Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PresRat correction #215

Merged
merged 189 commits into from
Jul 23, 2024
Merged

PresRat correction #215

merged 189 commits into from
Jul 23, 2024

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    b27df73 View commit details
    Browse the repository at this point in the history
  2. feat: ZeroRateMixin()

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    db261ca View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb4d1b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    092a00a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    551f54a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c196447 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e91b219 View commit details
    Browse the repository at this point in the history
  8. PresRat using ZeroRateMixin

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b025c9f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cbb09d2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0d0d533 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7af50e6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5cc97ff View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    13d9cb1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    59f087e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    aa9d134 View commit details
    Browse the repository at this point in the history
  16. test: zero_precipitation_rate()

    Checking some edge cases that were wrong before.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    500ad66 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    43ba757 View commit details
    Browse the repository at this point in the history
  18. fix, doc: Typo 'monthly'

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e51394c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9be8176 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    d598b07 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    5af60fb View commit details
    Browse the repository at this point in the history
  22. style: Fixing code style

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    695e2d9 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    b014d56 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f2253c9 View commit details
    Browse the repository at this point in the history
  25. test: Adding back a small noise on future projections

    This should avoid singularities while not changing the averages.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ac17b81 View commit details
    Browse the repository at this point in the history
  26. test: Defining some resources used in the tests

    It should help to follow the logic of the tests applied.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8ce668f View commit details
    Browse the repository at this point in the history
  27. clean, test:

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    672fc61 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    754268f View commit details
    Browse the repository at this point in the history
  29. test, clean: Combining tests

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    008056f View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d546ded View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    1063780 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    0888dda View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    c166c0e View commit details
    Browse the repository at this point in the history
  34. style:

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    077c5e7 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    1fb6c19 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    81ae605 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    edd3005 View commit details
    Browse the repository at this point in the history
  38. feat: apply_zero_precipitation_rate()

    Rolling back to pass the tests before moving again to the newer
    formulation.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b5731c2 View commit details
    Browse the repository at this point in the history
  39. feat: get_spatial_bc_presrat()

    Hopefuly we won't need to use it, but let's lock what is working now to
    help to figure out where is the problem.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    98f3bf0 View commit details
    Browse the repository at this point in the history
  40. fix, test: test_presrat_transform_nochanges()

    Fixed this test. The issue is that gridpoints missing historical
    references are skipped, and then there is an implicit interpolation
    resulting in approximated values that fail precise comparisons.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d7ddd23 View commit details
    Browse the repository at this point in the history
  41. feat: Saving requirements to estimate K factor

    Saving mf and mh explicitly since we should be able to simplify the
    operation. For now, saving monthly but it should transitioned later.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1730a81 View commit details
    Browse the repository at this point in the history
  42. Adding time indices

    Coordinate and time are decoupled from the data. To be able to run
    monthly means we shall include it. To keep consistent with the rest of
    the library, let's add a couple more arguments.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    bee4950 View commit details
    Browse the repository at this point in the history
  43. fix: zero_precipitation_rate() dealing with NaN

    The non-finite values should be ignored in the statistics.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    39bae3f View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    a368708 View commit details
    Browse the repository at this point in the history
  45. fix: Missing to load xarray

    It's actually only used in the prototype of the monthly means
    replacement, but let's add it already anyways.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    262f7c2 View commit details
    Browse the repository at this point in the history
  46. refact: get_spatial_bc_quantiles returing params as dict

    This avoids too many explicit arguments. For instance, PresRat requires
    variables related to the K parameter.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    52e167b View commit details
    Browse the repository at this point in the history
  47. feat: local_presrat_bc()

    Pass on all (current) tests. Recording it before refactoring.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9f08e37 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    d764202 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    aa0cf22 View commit details
    Browse the repository at this point in the history
  50. Locking numpy to < 2.0

    It's safer to hold for now and wait for the ecosystem to stabilize
    before moving.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d426e83 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    6cc7bf6 View commit details
    Browse the repository at this point in the history
  52. test: Updating fut_cc_notrend() to match the 'resource'

    Despite using the very same file, sup3r manipulate the dataset and
    expect some patterns without reinforcing it, leading to quiet errors.
    The modifications here match the expected dataset by sup3r so we can
    validate results.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    abeae3d View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    e70beb3 View commit details
    Browse the repository at this point in the history
  54. feat: PresRat.write_outputs()

    Recording it before the refactoring and integration with QDM.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    42a46dc View commit details
    Browse the repository at this point in the history
  55. fix, doc: Weird string literal issue

    It looks like a bug in pylinter, but it's easier to just avoid it.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b95adfe View commit details
    Browse the repository at this point in the history
  56. style: Sorting imports

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5650c19 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    c1af8db View commit details
    Browse the repository at this point in the history
  58. test: Improving test_presrat_calc()

    Checking more details in the output.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a09f9f0 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    8c8a28a View commit details
    Browse the repository at this point in the history
  60. style: Code formating

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2d997f5 View commit details
    Browse the repository at this point in the history
  61. test, refact: Conforming normalizing dataset

    sup3r expects data in a certain way and implicitly apply some
    transformations, so it is required to conform with that to be able to
    compare answers.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8be8e0e View commit details
    Browse the repository at this point in the history
  62. style: Missing space

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f5fabba View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    1d26fe8 View commit details
    Browse the repository at this point in the history
  64. style: Unused import

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8b8e7b0 View commit details
    Browse the repository at this point in the history
  65. test, fix: Missing a few fixtures

    Figuring out the minimum requirements to run.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6fd0cc0 View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    d56b969 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    218ad86 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    7ac12b4 View commit details
    Browse the repository at this point in the history
  69. Bump Python to 3.11.9

    It should work fine with any Python 3.11.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8c45370 View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    59caf0c View commit details
    Browse the repository at this point in the history
  71. style: UP039

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f0c5b48 View commit details
    Browse the repository at this point in the history
  72. fix: Wrong type

    Thanks to @bnb32 for noticing that!
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    da42586 View commit details
    Browse the repository at this point in the history
  73. doc: local_presrat_bc()

    Initializing documentation but more work to be done here.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    925be43 View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    87681eb View commit details
    Browse the repository at this point in the history
  75. cfg: Adding UP039 as fixable

    Simple enough to have now doubts, so take advantage of `--fix`.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2e73183 View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    9d93140 View commit details
    Browse the repository at this point in the history
  77. doc: Adding TODO label

    As suggested by @bnb32.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7a04ef7 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    9a480fd View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    734b780 View commit details
    Browse the repository at this point in the history
  80. fix: Wrong type

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    43645e3 View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    1a9a7fa View commit details
    Browse the repository at this point in the history
  82. cfg: Adding E303 as auto fix

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c8bf9ef View commit details
    Browse the repository at this point in the history
  83. Configuration menu
    Copy the full SHA
    e1eb618 View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    88385e8 View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    ebd253f View commit details
    Browse the repository at this point in the history
  86. Configuration menu
    Copy the full SHA
    f330ef4 View commit details
    Browse the repository at this point in the history
  87. Configuration menu
    Copy the full SHA
    27f2f0d View commit details
    Browse the repository at this point in the history
  88. Configuration menu
    Copy the full SHA
    00d3ed0 View commit details
    Browse the repository at this point in the history
  89. clean: Removing functions in development

    Future implementation for moving windows that are not ready yet.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e61078a View commit details
    Browse the repository at this point in the history
  90. Configuration menu
    Copy the full SHA
    c082d6c View commit details
    Browse the repository at this point in the history
  91. test, feat: Replacement for FP_NSRDB on the fly

    Creating support for custom datasets for training created on the fly.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5b95432 View commit details
    Browse the repository at this point in the history
  92. Configuration menu
    Copy the full SHA
    de7cf0f View commit details
    Browse the repository at this point in the history
  93. style: Fixing conding style

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ee0ad00 View commit details
    Browse the repository at this point in the history
  94. Configuration menu
    Copy the full SHA
    3d5adb8 View commit details
    Browse the repository at this point in the history
  95. doc, test: Adding documentation title for new functions

    All related to synthetic data for testing. I must improve those before
    the final PR.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fa44421 View commit details
    Browse the repository at this point in the history
  96. Configuration menu
    Copy the full SHA
    98c2bc8 View commit details
    Browse the repository at this point in the history
  97. fix: _get_factors() assume descending latitudes

    And sliently does the wrong thing otherwise.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    cb4253e View commit details
    Browse the repository at this point in the history
  98. fix: Assumptions should be reinforced

    Whenever an assumption is required, it must be reinforced to avoid
    silent errros and wasted time debugging those.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b8efcb2 View commit details
    Browse the repository at this point in the history
  99. Configuration menu
    Copy the full SHA
    95b9a7a View commit details
    Browse the repository at this point in the history
  100. Configuration menu
    Copy the full SHA
    db15751 View commit details
    Browse the repository at this point in the history
  101. test, fix: Using numpy we must conform with dimension order

    Unfortunately we can't do much about that while using numpy.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c3314b5 View commit details
    Browse the repository at this point in the history
  102. Configuration menu
    Copy the full SHA
    aedb2a6 View commit details
    Browse the repository at this point in the history
  103. test, refact: Running in parallel

    At some point moved to serial to help debugging but forgot that.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d07bd6d View commit details
    Browse the repository at this point in the history
  104. clean, test: Removing variables not used anymore

    Moved to use synthetic data, so reference (global) variables are not
    based anymore in a fixed sample data file, but instead are prescribed
    and govern the training data.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7b61575 View commit details
    Browse the repository at this point in the history
  105. fix, test: Left behind a filename reference without updating

    Related to the migration to synthetic sample data.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f691bb1 View commit details
    Browse the repository at this point in the history
  106. Configuration menu
    Copy the full SHA
    68b525f View commit details
    Browse the repository at this point in the history
  107. style, test:

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0ff0377 View commit details
    Browse the repository at this point in the history
  108. clean: Unused variable

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    021ebaa View commit details
    Browse the repository at this point in the history
  109. style: Empty space

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ae7b542 View commit details
    Browse the repository at this point in the history
  110. Configuration menu
    Copy the full SHA
    3f268f4 View commit details
    Browse the repository at this point in the history
  111. clean: Time index is not used here yet

    It will be needed later, but let's keep it clean for now.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    acf5429 View commit details
    Browse the repository at this point in the history
  112. Configuration menu
    Copy the full SHA
    40ec538 View commit details
    Browse the repository at this point in the history
  113. clean: Using global test definitions

    Removing old hardcoded testing variables in favor of global general
    test guiding variables.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    cfd8962 View commit details
    Browse the repository at this point in the history
  114. fix: Missing arguments for QDM applications

    It was missing custom inputs for `dist` and `relative`.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5d85e11 View commit details
    Browse the repository at this point in the history
  115. Configuration menu
    Copy the full SHA
    3b2f727 View commit details
    Browse the repository at this point in the history
  116. Dirty proof of concept for K-factor

    This is a different interpretation where x's denominator is also
    corrected, i.e. mh-corrected, which by definition is approximated to oh.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    31b2823 View commit details
    Browse the repository at this point in the history
  117. cfg: Updating pixi.lock

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ee35e12 View commit details
    Browse the repository at this point in the history
  118. fix: get_spatial_bc_quantiles() now returns params groupped

    I lost that change by mistake while rebasing.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1925a0d View commit details
    Browse the repository at this point in the history
  119. doc: Improving reference for more information on PresRat

    Althought `PresRat` is indeed derived from
    `QuantileDeltaMappingCorrection`, it is best to refer to `bias.PresRat`
    even if that will require the user to finally reach to
    `QuantileDeltaMappingCorrection` for more details.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    98a0e7b View commit details
    Browse the repository at this point in the history
  120. doc, fix: get_spatial_bc_presrat()

    Returning too many variables. Better do it at least groupped in a
    dictionary.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4e7c9fc View commit details
    Browse the repository at this point in the history
  121. style:

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    97b941d View commit details
    Browse the repository at this point in the history
  122. Configuration menu
    Copy the full SHA
    329c249 View commit details
    Browse the repository at this point in the history
  123. Configuration menu
    Copy the full SHA
    69329eb View commit details
    Browse the repository at this point in the history
  124. refact: Conforming with QDM on input arguments order

    Also, reinforcing named arguments to avoid errors.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a633653 View commit details
    Browse the repository at this point in the history
  125. refactor: New default value for zero rate's threshold

    New threshold is zero as requested by @grantbuster.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3618224 View commit details
    Browse the repository at this point in the history
  126. A task to run pytest

    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e50edfa View commit details
    Browse the repository at this point in the history
  127. Replicating time varing QDM in PresRat procedure

    A lot of redundancy. Make it work correctly first, optimize later.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    dbab2d2 View commit details
    Browse the repository at this point in the history
  128. Configuration menu
    Copy the full SHA
    bd2af81 View commit details
    Browse the repository at this point in the history
  129. Still saving estimated zero rate for now

    We might not need that anymore with the new formulation.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2379b99 View commit details
    Browse the repository at this point in the history
  130. Configuration menu
    Copy the full SHA
    9a7c7ea View commit details
    Browse the repository at this point in the history
  131. test: Updating test_presrat_calc_params()

    With the time dependent QDM, it would require a larger testing data to
    pass on this one. We might want to pay the price of a larger training
    data since the actual data shouldn't have such gap.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    982bc2d View commit details
    Browse the repository at this point in the history
  132. test, fix: Cleaning old fp_fut_cc

    The fp_fut_cc() will now refer to a synthetic dataset.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d734d90 View commit details
    Browse the repository at this point in the history
  133. Configuration menu
    Copy the full SHA
    9ddc1b7 View commit details
    Browse the repository at this point in the history
  134. refact: Changing standard to NT=24

    Let's take as new standard to estimate on 24 times along the year with
    time windows of 30, i.e. every 15 days a monthly scale estimate.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c0e6c5a View commit details
    Browse the repository at this point in the history
  135. Configuration menu
    Copy the full SHA
    e71624d View commit details
    Browse the repository at this point in the history
  136. fix: bias_transforms._get_factors() assume descending lats

    It sliently error returning a stripe instead of a tile.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e403406 View commit details
    Browse the repository at this point in the history
  137. Reinforce expected sorting by _get_factor()

    Get bias_transforms._get_factors() assume lat is descending and
    longitude to be ascending, and sliently fails if otherwise. This checks
    the order and fails if not satisfied.
    
    Without this protection it silently fails and have misleaded before
    where is the error.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    25b2464 View commit details
    Browse the repository at this point in the history
  138. Remove check on tau_fut

    A decision to be made here. With the time dependent QDM/PresRat, we
    require a larger testing data to guarantee coverage and avoid NaN.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2c0c3ac View commit details
    Browse the repository at this point in the history
  139. refact: Better selection on time centers

    With a set it guarantee to run only on valid times.
    castelao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0f8427c View commit details
    Browse the repository at this point in the history
  140. Configuration menu
    Copy the full SHA
    c485a57 View commit details
    Browse the repository at this point in the history
  141. Configuration menu
    Copy the full SHA
    a92435e View commit details
    Browse the repository at this point in the history
  142. Configuration menu
    Copy the full SHA
    dd9c143 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    ebe2503 View commit details
    Browse the repository at this point in the history
  2. refact: mf dataset redefined

    Offset based on the characteristics of the dataset itself.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    de2d9cf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10c43b9 View commit details
    Browse the repository at this point in the history
  4. refact, test: PresRat (pre) calcualtion of parameters

    Re-organizing tests, combining redundant, and cleaning.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0ff04c8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b035c49 View commit details
    Browse the repository at this point in the history
  6. test: Extending synthetic resources to a full year

    Now with a time dependent QDM, we need a full year coverage or we get
    NaN CDFs.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4177594 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e914da8 View commit details
    Browse the repository at this point in the history
  8. style: Formating

    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    442b125 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3fabd4c View commit details
    Browse the repository at this point in the history
  10. test, refact: Extending sample data for a longer time series

    With the time dependent QDM, it requires a full coverage sample to avoid
    NaN.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6dcd0da View commit details
    Browse the repository at this point in the history
  11. refact, test: Renaming variables

    Making clear who are the CC and FUT_CC datasets.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    cb20e24 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    426ea70 View commit details
    Browse the repository at this point in the history
  13. doc, test: More info

    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6b473b8 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    32aed4c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7d036d5 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    aa92d63 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    40bba8e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    9f21963 View commit details
    Browse the repository at this point in the history
  19. fix: local_presrat_bc time_index argument order

    QDM changed the argument order to keep consistency with the rest of the
    library, thus presrat should also change.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    86abd8c View commit details
    Browse the repository at this point in the history
  20. doc, fix: Correcting arguments definitions

    Error noticed by @grantbuster
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e079828 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    bf42f3e View commit details
    Browse the repository at this point in the history
  22. doc: _get_factors()

    Get factors was a chunk of original get_spatial_bc_factors() stripped
    out to be re-used and avoid redundancy. It is identical to original code
    to avoid breaking other parts of the package.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    bfa519f View commit details
    Browse the repository at this point in the history
  23. doc, fix: Fixing get_spatial_bc_quantiles()

    Documentation was outdated. With PresRat, there are even more parameters
    to recover, so to keep consistency this was changed to return a
    dictionary of parameters.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c9b69f7 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    e63b59c View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    d422341 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    3483600 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    0aaf49b View commit details
    Browse the repository at this point in the history
  28. test, fix: Fixed test_presrat_transform_nochanges()

    It was missing to force K=1, otherwise any difference in the means would
    result in a K that would change the unbiased.
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    9b391f5 View commit details
    Browse the repository at this point in the history
  29. refact: Removing apply_zero_precipitation_rate()

    Removing apply_zero_precipitation_rate() as requested by @grantbuster
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0a78b31 View commit details
    Browse the repository at this point in the history
  30. refact: PresRat with no_trend reduces to ordinary QDM

    If no_trend is True, skip zero rate and k-factor corrections.
    
    As requested by @grantbuster
    castelao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3459e02 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    06b1b5b View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    6e30c3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b51d19e View commit details
    Browse the repository at this point in the history
  3. fix: Incomplete assert check

    Thanks to @grantbuster who noticed that.
    castelao committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4e12610 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e401b30 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ed7bcea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ac962a3 View commit details
    Browse the repository at this point in the history
  7. doc: More information on tests

    Some information for future refactoring.
    castelao committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4ecd0a8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7e3873b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b548eb8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d9bc92d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0238519 View commit details
    Browse the repository at this point in the history
  12. cfg: Updating pixi.lock

    castelao committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7394427 View commit details
    Browse the repository at this point in the history
  13. fix: Removing method zero_rate_threshold

    I missed this method from an early stage implementation. Thanks to
    @grantbuster who noticed that!
    
    Also defining default `zero_rate_threshold` to zero as requested by
    Grant.
    castelao committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0b81c67 View commit details
    Browse the repository at this point in the history
  14. fix: zero_precipitation_rate()

    The rate should be <= otherwise we would miss completely the case of a
    threshold equal to zero.
    
    Thanks to @grantbuster who noticed that.
    castelao committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    95f2e00 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b5ab7f9 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    fd4f453 View commit details
    Browse the repository at this point in the history