Pipeline requires explicit arguments for QuantileDeltaMappingCorrection #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantbuster
approved these changes
Apr 29, 2024
|
Can you also add no_trend kwarg to the base DataHandler object? |
bnb32
requested changes
May 1, 2024
|
@castelao The mac tests might pass after you rebase on main (aka remove the netCDF4 dep) |
castelao
force-pushed
the
fix/QDM_explicit_args
branch
from
1d43216
to
aac6a8f
Compare
|
@castelao looks good but can you add the |
castelao
force-pushed
the
fix/QDM_explicit_args
branch
from
aac6a8f
to
4383803
Compare
@bnb32 , is this still a request? |
|
Shall we merge this one? Is it missing anything? |
bnb32
approved these changes
May 13, 2024
All good! |
castelao
referenced
this pull request
May 13, 2024
As requested by @grantbuster, to qdm_bc() can pass along a 'no_trend' option to QDM correction.
Bug introduced on f0840f2
It's possible to infer the resulting offset from the theory, so we don't need to save the full matrix of outputs.
Validate two aspects: - We should be able to run a forward pass in a unbiased data. - The bias trend should be observed in the predicted output.
clean: Unused variables style: unused variable
castelao
force-pushed
the
fix/QDM_explicit_args
branch
from
1cfaf51
to
aea7b34
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2024
Pipeline requires explicit arguments for QuantileDeltaMappingCorrection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grantbuster raised the point that the pipeline system requires explicit argument to orchestrate the inputs.