Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation, requires tags to figure out version #202

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

castelao
Copy link
Member

When checking repository, include tags history to allow figuring out the current package version.

Check the version shown at https://nrel.github.io/sup3r/ to understand the issue.

When checking repository, include tags history to allow figuring out
the current package version.

Check the version shown at https://nrel.github.io/sup3r/ to understand
the issue.
@castelao castelao requested a review from bnb32 March 21, 2024 19:04
@castelao castelao self-assigned this Mar 21, 2024
Copy link
Collaborator

@bnb32 bnb32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@castelao castelao marked this pull request as ready for review March 22, 2024 20:54
@castelao
Copy link
Member Author

Good catch!

Thanks!

@castelao castelao merged commit 052c1ae into main Mar 22, 2024
12 checks passed
@castelao castelao deleted the fix/doc_version branch March 22, 2024 20:55
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
* fix: Documentation requires tags to figure out version

When checking repository, include tags history to allow figuring out
the current package version.

Check the version shown at https://nrel.github.io/sup3r/ to understand
the issue.

* Simplifying installation using optional dependencies

* Using cached PIP

* Using Py-3.10 to build documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants