Syntax update using numpy and scipy #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced by np.prod()
The `scipy.ndimage.filters` namespace is deprecated and will be removed in SciPy 2.0.0
I just noticed that although numpy and scipy are used explicitly in sup3r, there was no explicit dependency on those. The respective minimum versions where defined based on the syntax update in the previous commit.
bnb32
approved these changes
Mar 15, 2024
There is something going wrong with TF-2.16 (see PR #198).
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* fix: np.product() is deprecated Replaced by np.prod() * fix: gaussian_filter() moving to scipy.ndimage The `scipy.ndimage.filters` namespace is deprecated and will be removed in SciPy 2.0.0 * Explicit requirement on numpy and scipy I just noticed that although numpy and scipy are used explicitly in sup3r, there was no explicit dependency on those. The respective minimum versions where defined based on the syntax update in the previous commit. * Holding TensorFlow to <2.16 There is something going wrong with TF-2.16 (see PR #198).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor editing that would stop some warnings about a future change in syntax.
I also added explicit dependency on
numpyandscipysince those are explicitly called.