Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gb/precip skill #195

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Gb/precip skill #195

merged 4 commits into from
Mar 28, 2024

Conversation

grantbuster
Copy link
Member

No description provided.

@grantbuster grantbuster requested a review from bnb32 March 8, 2024 18:13
bnb32
bnb32 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@bnb32 bnb32 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. What's happening with the tests though?

Apparently tensorflow 2.16 made some big API changes. I added <2.16 to the requirements in my PR.

@grantbuster
Copy link
Member Author

Looks good to me. What's happening with the tests though?

Apparently tensorflow 2.16 made some big API changes. I added <2.16 to the requirements in my PR.

I bet it's that? I rebased on main and trying tests again...

@grantbuster grantbuster merged commit d710fe3 into main Mar 28, 2024
8 checks passed
@grantbuster grantbuster deleted the gb/precip_skill branch March 28, 2024 20:00
github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
@grantbuster
Merge pull request #195 from NREL/gb/precip_skill
976cfae 
Gb/precip skill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb32 bnb32 bnb32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grantbuster @bnb32