Bug fix for conditional moment with topography #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnb32
requested changes
May 12, 2023
9849e8c
to
4181518
Compare
|
So after testing further, this PR only slows down the way the batches are assembled for the conditional moment model that use topography, which should be expected. @bnb32 I think we can consider this as ready to be re-reviewed and we can revisit it at later times if needed. The execution time is the same when not using sub filter + topography |
bnb32
approved these changes
Jul 17, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Bug fix for conditional moment with topography
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation of the second moment when using exogenous data was not working when we need to call the first moment in the batch handler. The batch handler needs to call the first moment with low res and the exogenous data rather than just the low res.