Various enhancements and fix for conditional moment #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
malihass
commented
Mar 23, 2023
malihass
commented
- Add padding for end of time interval
- Fix simple enhancement for space and time used to create the sub filter
- Enable the use of linear time enhancement
bnb32
requested changes
Apr 6, 2023
|
@malihass is this still draft? |
Yeah, I am running a few cases to verify that the linear time + the end padding work as expected. Eagle went back online so I'll try to process these asap and convert this to a regular PR |
Cool, @bnb32 is drafting a new release (v0.1.0). Check in with him if you want these changes to be part of the release. |
bnb32
approved these changes
Apr 13, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
Various enhancements and fix for conditional moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.